fix(forms): Refactoring migration logic to skip orphan elements messages, and improve default value handling for some question types #19474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccailly
force-pushed
the
fix/forms-migration-skip-orphan-default-values
branch
from
5a15bd6 to
839332b
Compare
AdrienClairembault
approved these changes
Apr 29, 2025
ccailly
force-pushed
the
fix/forms-migration-skip-orphan-default-values
branch
from
839332b to
500d763
Compare
…improve default value handling for some question types
…sections and questions
cedric-anne
force-pushed
the
fix/forms-migration-skip-orphan-default-values
branch
from
500d763 to
5180399
Compare
cedric-anne
requested changes
Apr 29, 2025
cedric-anne
approved these changes
Apr 29, 2025
trasher
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Removal of “useless” warning messages.
Added error handling for question imports.
Fixed default value conversion methods for selectables and urgency questions.